-
Notifications
You must be signed in to change notification settings - Fork 513
Add service worker for offline access to editor #1984
base: master
Are you sure you want to change the base?
Conversation
I need some advice on what to do with a few things. Running the editor page 100% offline works, however, we'll need to add special cases to deal with all of this:
It's also hard to know when you're actually offline completely. There is @flukeout, @gideonthomas can we discuss soon? I'd like to get this in before May. |
I like your solution @humphd - makes sense. If you can just slap an |
OK, so if we're happy with this general direction, I think we can start by getting this PR into shape and land it, then do follow-up PRs that add the UI stuff based on the events I'm adding. I'll do a bit more work on this and get it ready for review. |
@gideonthomas I am seriously confused at how Thimble loads, and I'm hoping you can help me fix it. Basically, I want to do the following:
Some of this we could do in new PRs vs. this one. Another question: I've only done the service worker cache stuff for the |
@humphd let's chat about this over a call? I'm not sure I fully understand the scope of the problems. |
This is still in progress, but it's starting to work (I was able to load the editor fully offline). I'll keep iterating on it.
It's a bit different than what I had to do in Brackets because of the dynamic nature of our URLs, especially with localization adding lang info to everything. I'd like to figure out how to move more of our CSS, JS, and images to precache vs. dynamic. I don't understand why they don't seem to exist in
dist/
builds.