Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

WIP: Implement BitmapData#getColorBoundsRect #2213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tschneidereit
Copy link
Contributor

And required fixes to BitmapData. Very WIP, much broken.

There is so much inconsistency in BitmapData, particularly around handling of color formats. I think we need to clean all that up, and sooner rather than later, to be able to say, with a straight face, that we support any methods on BitmapData at all.

In particular, various methods just assume the data to be in pARGB format, while others think it's uRGBA. With some uncertainty about byte order sprinkled in. The comment on _ensureBitmapData tells a story about converting things to uRGBA, but the implementation converts to pARGB.

Fun.

Review on Reviewable

And required fixes to BitmapData. Very WIP, much broken.
@tschneidereit
Copy link
Contributor Author

/cc @mbebenita

@tschneidereit
Copy link
Contributor Author

Oh and also, getColorBoundsRect absolutely requires some unpremultiplied format. Which one doesn't matter much, though.

@tbtlr
Copy link
Contributor

tbtlr commented Oct 14, 2015

@tschneidereit can you please resolve the mergin conflicts if this is still something we want to land. I can do the review then. If not, please close this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants