test exceeding and increasing the map size #82
Conversation
|
@rnewman How does this look? (Perhaps it makes sense to add an |
src/env.rs
Outdated
| builder.set_map_size(1024 * 1024 * 10 /* 10,485,760 bytes, i.e. 10MiB */); | ||
| let k = Rkv::from_env(root.path(), builder).unwrap(); | ||
| let sk: Store = k.open_or_create_default().expect("opened"); | ||
| let val = "x".repeat(1024 * 1024 /* 1,048,576 bytes, i.e. 1MiB */); |
There was a problem hiding this comment.
You should make sure that this test and the one above use the same value or size (maybe fn get_larger_than_default_map_size_value()), and are thus related more closely. Consider a year from now when the default bumps to 2MB, and/or set_map_size accrues a bug. The first test will break, and this one will not, because this value is now smaller than the limit.
There was a problem hiding this comment.
Good point, I've refactored references to the default map size into a get_larger_than_default_map_size_value() function that both tests use to determine a value slightly larger than the default map size.
This refactors determination of a value larger than the default map size to reduce the risk of tests diverging if the default map size changes in the future.
Per the comment from @shivawu in #34 that there should be a way to set an environment's map size, here are tests that demonstrate how to do that.
NB: We should file upstream bugs/PRs in the LMDB crate and C library to fix the code or docs (probably the latter) to agree about the default map size for an LMDB environment.