This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
Fix compatibility with Phusion Passenger #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadgeKit calls `app.listen()` based on whether `module.parent` is null. But when BadgeKit is loaded from Passenger, `module.parent` is not null because Passenger does not run `index.js` directly, but `require()`s it from another file. So in this commit we also check for `module.parent.isApplicationLoader` in the conditional. Passenger sets this flag, and it is proposed that other apps (e.g. PM2) could set this flag in the future too. The `module.parent.isApplicationLoader` mechanism is used by for example the CompoundJS framework, which suffered from a similar problem. The discussion is here: https://groups.google.com/forum/#!topic/phusion-passenger/6Cojr55tzfw The mechanism is documented in the Passenger 4.0.34 changelog entry: https://github.com/phusion/passenger/blob/release-5.0.6/CHANGELOG#L577-L590 This issue was originally reported here: phusion/passenger#1460 mozilla#477
|
Any updates on this? This should be a pretty simple patch that wouldn't interfere with anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BadgeKit calls
app.listen()based on whethermodule.parentis null. But when BadgeKit is loaded from Passenger,module.parentis not null because Passenger does not runindex.jsdirectly, butrequire()s it from another file.So in this commit we also check for
module.parent.isApplicationLoaderin the conditional. Passenger sets this flag, and it is proposed that other apps (e.g. PM2) could set this flag in the future too.The
module.parent.isApplicationLoadermechanism is used by for example the CompoundJS framework, which suffered from a similar problem. The discussion is here:https://groups.google.com/forum/#!topic/phusion-passenger/6Cojr55tzfw
The mechanism is documented in the Passenger 4.0.34 changelog entry:
https://github.com/phusion/passenger/blob/release-5.0.6/CHANGELOG#L577-L590
This issue was originally reported here:
phusion/passenger#1460
#477