Use "http" fixture per session to increase test runtime drasticallly #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compared with CI checks that were running until now the duration drops from around 3:30 minutes to just 1 minute! |
Girl1981
approved these changes
Jul 10, 2024
Girl1981
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that tests that are only using data from the local HTTP server are running very slow. After investigation it turned out that the HTTP server's shutdown method takes about 0.5s to run. I filed web-platform-tests/wpt#46710 to get this investigated.
To workaround the issue we should use the
httpfixture per session and not per test.