Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packaging requirement for version 21.3.0 #640

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix packaging requirement for version 21.3.0 #640

merged 1 commit into from
Apr 5, 2023

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Apr 4, 2023

None of the tests use the packaging module but mozdownload code itself. So my patch on #636 was actually wrong and this PR fixes it.

@whimboo whimboo added this to the 1.28.0 milestone Apr 4, 2023
juliandescottes
juliandescottes approved these changes Apr 4, 2023
View reviewed changes
Copy link

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems straightforward. No usage of packaging in tests, also verified that tests run fine on a fresh clone with those changes.

@whimboo whimboo merged commit 812e1df into mozilla:master Apr 5, 2023
@whimboo whimboo deleted the packaging branch April 5, 2023 06:00
@whimboo whimboo mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliandescottes juliandescottes juliandescottes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@whimboo @juliandescottes