Show link to Looker event monitoring dashboard for all metrics with t…

…ype=event (#2246)
mozilla · Jun 4, 2024 · f75b25f · f75b25f
1 parent 77fe338
commit f75b25f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/etl/glean_etl.py b/etl/glean_etl.py
@@ -496,7 +496,7 @@ def write_glean_metadata(output_dir, functions_dir, app_names=None):
                     ping_data[ping_name].update(glam_metadata)
 
                     event_monitoring_metadata = get_looker_monitoring_metadata_for_event(
-                        app, app_group, metric, ping_name
+                        app, app_group, metric
                     )
                     if event_monitoring_metadata:
                         ping_data[ping_name].update({"event_monitoring": event_monitoring_metadata})

diff --git a/etl/looker.py b/etl/looker.py
@@ -265,10 +265,7 @@ def get_looker_explore_metadata_for_metric(
     return None
 
 
-def get_looker_monitoring_metadata_for_event(app, app_group, metric, ping_name):
-    if ping_name != "events":
-        return None
-
+def get_looker_monitoring_metadata_for_event(app, app_group, metric):
     metric_type = metric.definition["type"]
     if metric_type != "event":
         return None