Skip to content

Commit

Permalink
Make ./mach package usable
Browse files Browse the repository at this point in the history
- without options, `strip` strips all sections containing `.comment` section.
- Haiku's dynamic loader uses this section to check what architecture of library is required from binary. If absent, it implies 32bit version of library.
- Then, firefox failed to start by failing to check on 64bit only depending library (c.f. libplds4.so).
- This commit works around this by specifying `strip` option not to remove `.comment` section.
  • Loading branch information
kenz-gelsoft committed Oct 14, 2024
1 parent a3fd95a commit bba4632
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions moz.configure
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,8 @@ def strip_flags(flags, profiling, target):
# On Darwin, it tries to strip things it can't, so we need to limit its scope.
elif target.kernel == "Darwin":
return ["-x", "-S"]
elif target.kernel == "Haiku":
return ["--strip-debug"]


set_config("STRIP_FLAGS", strip_flags)
Expand Down

0 comments on commit bba4632

Please sign in to comment.