This repository has been archived by the owner on Sep 4, 2023. It is now read-only.
Native messaging #105
Closed
Native messaging #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for a more progressive experience. Probably set this back to something larger later on!
Makes deployment of a stand-alone extension much easier
# Conflicts: # extension/manifest.json
They're not useful for me
It now handles model management on its own, and has an API much more similar to AsyncService. I've shimmed InPageTranslation to communicate directly with it for now.
I want interactive elements to always be translated before off-screen elements, even when they pop up later on the page
Can't call it "simplify" anymore now, can I?
Also keep translating on navigating unless you change domain or change tab.
This reverts commit fe0beeb.
Try to reuse existing DOM elements in favour of inserting new ones. Hopefully, this way we don't use any javascript references or event listeners registered to the DOM nodes that are already in the document. I've added a bit of instrumentation to see whether something ends up not making sense. So far, that is happening quite often. Not sure yet whether that's a bug in my code, whether bergamot-translator is not passing on all HTML elements, or whether the DOM changed between submitting the innerHTML for translation, and receiving the translation back.
And I don't care about attribute changes at the moment
If they're deleted from the document, we'll never see them again anyway.
Because the cache key depends on ccache being available
The whole purpose of this plugin is dogfooding those improvements.
Changes to cache ccache build via emscripten to save about 4 minutes of build time. The generation of ccache-vars are using system commands and are pushed further up.
Save built ccache into GitHub cache
Include the extension ID I have been using up till now
…erHTML` is valid HTML
Including adapting to new API that allows for options per request
Since a batch can now have the HTML option toggled per request.
…tion Hard-coded to the language that translateLocally selects for you at the moment.
|
Apologies, Github and I had a bit of a miscommunication. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the WASM backend with an externally installed TranslateLocally.
Related pull request: XapaJIaMnu/translateLocally#93