Update tox matrix versions #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW if/when refactoring for 3.12 you also might want to get rid the separate GHA matrix config in Question here is whether you'd like the classifier versions: django-product-details/setup.py Lines 40 to 43 in 228b14c in sync with the versions being in the test matrix now (even that lower/higher might actually be compatible?) — i.e. drop the older Pythons somewhat officially if there are tests no longer ensuring compatibility… I'm only not sure whether that wouldn't warrant a release(?) Feel free to amend the dependencies as you see fit, I'd rather not touch these (only wanted to have more current tests without rewriting). |
janbrasna
commented
Jun 26, 2024
| @@ -27,20 +27,19 @@ def find_version(*file_paths): | |||
| packages=find_packages(), | |||
| include_package_data=True, | |||
| zip_safe=False, | |||
| install_requires=["Django>=2.2", "requests>=2.21.0"], | |||
| install_requires=["Django>=3.2", "requests>=2.26.0"], | |||
There was a problem hiding this comment.
TL;DR the rest is mostly metadata, so this is really the only impact here — basically moving the requires in line with what is pinned for testing, to have the visibility into confirming it truly working. Feel free to revert if you feel like still keeping the older (and fully working as of now) versions around.
janbrasna
commented
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing only Python versions 3.9–3.11 and Django 3.2+, 4.0.x, 4.2.x and 5.0.x ✅
(To support Python 3.12 a refactor is in the cards unfortunately, migrating away from imp, therefore replacing nose with nose2 or pynose or pytest)