Add command to delete erroneously added overgrowth NeedsHumanReview & reset due dates #22832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
approved these changes
Nov 7, 2024
Comment on lines
+585
to
+587
| reason=NeedsHumanReview.REASONS.HOTNESS_THRESHOLD, | ||
| created__range=ERRONEOUSLY_ADDED_OVERGROWTH_DATE_RANGE, | ||
| is_active=True, |
There was a problem hiding this comment.
I'm not a fan of how we have to query on the same things in two places but I can't immediately think of a way around it 😒
There was a problem hiding this comment.
Same. I could have generated some dictionaries of filters with an optional versions__ prefix but I figured this wasn't worth doing for a one-off.
eviljeff
pushed a commit
that referenced
this pull request
Nov 7, 2024
… reset due dates (#22832) * Add command to delete erroneously added overgrowth NeedsHumanReview & reset due dates * Add route
KevinMind
pushed a commit
that referenced
this pull request
Nov 8, 2024
… reset due dates (#22832) * Add command to delete erroneously added overgrowth NeedsHumanReview & reset due dates * Add route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to mozilla/addons#15141
Context
We introduced a new way to determine if an add-on should be flagged for abnormal growth but the new algorithm has a bug that caused a bunch of add-ons to be flagged erroneously. Operations want to delete the
NeedsHumanReviewflag from them all (can't just make it inactive, that would skew data in our stats about reviews) and reset their due dates to remove them from the queue.Note that the algorithm hasn't been fixed yet, because we still need to agree on what the solution is - but we want to clean up the queue quickly before reviewers get to it.
Testing
Unit test should be enough. We should only remove the NHR that were created for that specific reason, during the specific timeframe, that are still active.