Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1905093 - set googleapiclient retries to 3 #260

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Bug 1905093 - set googleapiclient retries to 3 #260

merged 2 commits into from
Jul 24, 2024

Conversation

gbrownmozilla
Copy link
Contributor

@gbrownmozilla gbrownmozilla commented Jun 27, 2024 •
edited
Loading

@gbrownmozilla gbrownmozilla marked this pull request as ready for review June 27, 2024 23:03
jcristau
jcristau requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is enough? AFAICT googleapiclient.discovery.build just uses num_retries for the _retrieve_discovery_doc request, but AFAICT we also need it everywhere else we make requests (i.e. pretty much all calls to execute in store.py)?

@gbrownmozilla
Copy link
Contributor Author

You are probably right. I haven't had a chance to look into this today; feel free to take it, or I can have another look after pto.

@gbrownmozilla gbrownmozilla merged commit 0f478e7 into mozilla-releng:master Jul 24, 2024
4 checks passed
@gbrownmozilla gbrownmozilla deleted the add-retries branch July 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcristau jcristau jcristau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbrownmozilla @jcristau