Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-10031 [Menu] Remove associated type from first enum #22111

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Refactor FXIOS-10031 [Menu] Remove associated type from first enum #22111

merged 1 commit into from
Sep 20, 2024

Conversation

adudenamedruby
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Title

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@adudenamedruby adudenamedruby requested a review from a team as a code owner September 20, 2024 14:18
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 31.18%
📖 Edited 4 files
📖 Created 0 files

Client.app: Coverage: 29.71

File Coverage
MainMenuAction.swift 100.0% ✅
MainMenuConfigurationUtility.swift 29.44% ⚠️
MainMenuState.swift 93.75% ✅

Generated by 🚫 Danger Swift against ec91023

@adudenamedruby adudenamedruby requested review from thatswinnie and removed request for cyndichin September 20, 2024 14:34
@adudenamedruby adudenamedruby merged commit cecc8dc into main Sep 20, 2024
10 checks passed
@adudenamedruby adudenamedruby deleted the rgb/refactorSomeReduxThings branch September 20, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adudenamedruby @mobiletest-ci-bot @thatswinnie