Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-9998 [inactive tabs] Fix crash when deleting and the undoing the inactive tabs multiple times in a row (related improvements FXIOS-9954, FXIOS-10010, FXIOS-9999) #22075

Merged
merged 25 commits into from
Sep 24, 2024
Merged

Bugfix FXIOS-9998 [inactive tabs] Fix crash when deleting and the undoing the inactive tabs multiple times in a row (related improvements FXIOS-9954, FXIOS-10010, FXIOS-9999) #22075

merged 25 commits into from
Sep 24, 2024

Commits on Sep 18, 2024

  1. Add helper getters and documentation. Minor improvements. Refactored … 

    …naming for clarity.
    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f9ce9df View commit details
    Browse the repository at this point in the history

  2. Rename inactiveTabs to normalInactiveTabs for clarity / consistency.

    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0bc827c View commit details
    Browse the repository at this point in the history

  3. no message

    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5b3c655 View commit details
    Browse the repository at this point in the history

  4. Fix to close the tab try when all tabs are inactive and closed at once.

    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d5650a0 View commit details
    Browse the repository at this point in the history

  5. Fix to refresh the active tab area when inactive tabs are closed, in … 

    …case an active tab has been generated.
    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ad35533 View commit details
    Browse the repository at this point in the history

  6. Add logic for findRightOrLeftTab to find a neighbouring tab to a remo… 

    …ved tab which does not require saving a subarray index prior to removing a the tab. Add unit tests.
    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6d0f301 View commit details
    Browse the repository at this point in the history

  7. Reworked logic for calculating the "next" index to select when removi… 

    …ng a tab, which properly takes into account inactive tabs. Cleaned up some old inactive tabs nimbus experiment code.
    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    79cabb2 View commit details
    Browse the repository at this point in the history

  8. Add a ton of removeTab tests which check edge cases and common situat… 

    …ions for normal active tabs, normal inactive tabs, and private tabs.
    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    84cd089 View commit details
    Browse the repository at this point in the history

  9. Cleanup documentation and add helper method for readability.

    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    77f8ec7 View commit details
    Browse the repository at this point in the history

  10. Fixes, swiftlint.

    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1d82937 View commit details
    Browse the repository at this point in the history

  11. Make sure TabManagerTests do not use debug timeout for inactive tabs.

    @ih-codes
    ih-codes committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    39bbcb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Revert refactor to rename inactiveTabs to normalInactiveTabs pending … 

    …additional discussion with team.
    @ih-codes
    ih-codes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    61e21e8 View commit details
    Browse the repository at this point in the history

  2. Swiftlint fix.

    @ih-codes
    ih-codes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5b00180 View commit details
    Browse the repository at this point in the history

  3. Bugfix: Take into account the browsing mode (normal or private) when … 

    …closing last inactive tabs. Add additional unit tests.
    @ih-codes
    ih-codes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    eea2001 View commit details
    Browse the repository at this point in the history

  4. Fix for comparing private tabs regardless of active/inactive state.

    @ih-codes
    ih-codes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6677ccb View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix tab comparison logic for predicate and add tests.

    @ih-codes
    ih-codes committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5904fbc View commit details
    Browse the repository at this point in the history

  2. Cleanup and updating documentation. Delete unneeded helper.

    @ih-codes
    ih-codes committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d12b1c0 View commit details
    Browse the repository at this point in the history

  3. Round out test cases for isSameTypeAs().

    @ih-codes
    ih-codes committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d569fb5 View commit details
    Browse the repository at this point in the history

  4. Bitrise test workaround for main thread issues related to FXIOS-10110.

    @ih-codes
    ih-codes committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    62ed2e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Documentation update.

    @ih-codes
    ih-codes committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    f8164b5 View commit details
    Browse the repository at this point in the history

  2. Rewrite test not to rely on the global notification center.

    @ih-codes
    ih-codes committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    4438f77 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Don't change package file.

    @ih-codes
    ih-codes committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    daca18a View commit details
    Browse the repository at this point in the history

  2. Test bumping timeout for Danger.

    @ih-codes
    ih-codes committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    168d9f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Test bypass.

    @ih-codes
    ih-codes committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    26b667a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'mozilla/main' into ih/FXIOS-9998-fix-cl… 

    …ose-inactive-tabs-crash
    @ih-codes
    ih-codes committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1cc5604 View commit details
    Browse the repository at this point in the history