Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MTE-3430 - Add Tracking protection test id 2307063 #21944

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

mdotb-moz
Copy link
Contributor

📜 Tickets

Jira ticket

💡 Description

Add test case https://mozilla.testrail.io/index.php?/cases/view/2307063 to the tracking protection test suite. Removed unused variables, cleaned the code and removed code that was waiting for an alert because now we shows a text instead of the alert.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mdotb-moz mdotb-moz requested review from a team as code owners September 13, 2024 11:55
@mdotb-moz mdotb-moz changed the title Add tracking protection test - id: 2307063 Add MTE-3430 - Add Tracking protection test id 2307063 Sep 13, 2024
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Sep 13, 2024

Messages
📖 Edited 2 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 4115fd5

@isabelrios isabelrios added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Sep 16, 2024
@isabelrios
Copy link
Contributor

Great work @mdotb-moz starting to create your first UI Test! The PR looks good. However, as discussed, adding Do not Merge label because there is one element that changes on iPad and the test needs to be updated with that.

let websiteWithBlockedElements = "twitter.com"
let differentWebsite = path(forTestPage: "test-example.html")
let trackingProtectionTestUrl = "https://senglehardt.com/test/trackingprotection/test_pages/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How stable is this website? We have had tests that depends on external sites that fail occasionally because the site was slow or implements a CAPTCHA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @clarmso . So far the page is pretty stable but once we use it in a CI environment maybe we can have some issues. The page is a very simple page, with just some links and the test is only opening the webpage, is not using any content. The manual test case use this url, this is why I used the same url. The point is that to check the tracking protection we have to check an element in the padlock in the urlbar, so technically we can use any page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webpage is a mozilla webpage so it should safe to use

@isabelrios isabelrios removed the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Sep 25, 2024
@mdotb-moz mdotb-moz merged commit b219ba3 into main Sep 25, 2024
10 of 11 checks passed
@mdotb-moz mdotb-moz deleted the mb/MTE-3430-TrackingProtection branch September 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants