-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MTE-3430 - Add Tracking protection test id 2307063 #21944
Conversation
Generated by 🚫 Danger Swift against 4115fd5 |
Great work @mdotb-moz starting to create your first UI Test! The PR looks good. However, as discussed, adding Do not Merge label because there is one element that changes on iPad and the test needs to be updated with that. |
let websiteWithBlockedElements = "twitter.com" | ||
let differentWebsite = path(forTestPage: "test-example.html") | ||
let trackingProtectionTestUrl = "https://senglehardt.com/test/trackingprotection/test_pages/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How stable is this website? We have had tests that depends on external sites that fail occasionally because the site was slow or implements a CAPTCHA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @clarmso . So far the page is pretty stable but once we use it in a CI environment maybe we can have some issues. The page is a very simple page, with just some links and the test is only opening the webpage, is not using any content. The manual test case use this url, this is why I used the same url. The point is that to check the tracking protection we have to check an element in the padlock in the urlbar, so technically we can use any page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The webpage is a mozilla webpage so it should safe to use
6742ec4
to
4115fd5
Compare
📜 Tickets
Jira ticket
💡 Description
Add test case https://mozilla.testrail.io/index.php?/cases/view/2307063 to the tracking protection test suite. Removed unused variables, cleaned the code and removed code that was waiting for an alert because now we shows a text instead of the alert.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)