Add FXIOS-9832 - Password Generator Feature Flag (#21590)

* Feature Flag Added * Addressed comments --------- Co-authored-by: Daniel Dervishi <[email protected]>
mozilla-mobile · Aug 23, 2024 · da61142 · da61142
1 parent cb1436b
commit da61142
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 0 deletions.
diff --git a/firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift b/firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift
@@ -29,6 +29,7 @@ enum NimbusFeatureFlagID: String, CaseIterable {
     case microsurvey
     case nativeErrorPage
     case nightMode
+    case passwordGenerator
     case preferSwitchToOpenTabOverDuplicate
     case reduxSearchSettings
     case closeRemoteTabs
@@ -91,6 +92,7 @@ struct NimbusFlaggableFeature: HasNimbusSearchBar {
                 .menuRefactor,
                 .nativeErrorPage,
                 .nightMode,
+                .passwordGenerator,
                 .preferSwitchToOpenTabOverDuplicate,
                 .reduxSearchSettings,
                 .reportSiteIssue,

diff --git a/firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift b/firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift
@@ -64,6 +64,9 @@ final class NimbusFeatureFlagLayer {
         case .nightMode:
             return checkNightModeFeature(from: nimbus)
 
+        case .passwordGenerator:
+            return checkPasswordGeneratorFeature(from: nimbus)
+
         case .preferSwitchToOpenTabOverDuplicate:
             return checkPreferSwitchToOpenTabOverDuplicate(from: nimbus)
 
@@ -247,6 +250,10 @@ final class NimbusFeatureFlagLayer {
         return config.productAds
     }
 
+    private func checkPasswordGeneratorFeature(from nimbus: FxNimbus) -> Bool {
+        return nimbus.features.passwordGeneratorFeature.value().enabled
+    }
+
     private func checkProductBackInStockFakespotFeature(from nimbus: FxNimbus) -> Bool {
         let config = nimbus.features.shopping2023.value()
 

diff --git a/firefox-ios/nimbus-features/passwordGeneratorFeature.yaml b/firefox-ios/nimbus-features/passwordGeneratorFeature.yaml
@@ -0,0 +1,17 @@
+# The configuration for the passwordGeneratorFeature feature
+features:
+  password-generator-feature:
+    description: Password Generator Feature
+    variables:
+      enabled:
+        description: If true, the password generator feature is enabled
+        type: Boolean
+        default: false
+    defaults:
+      - channel: beta
+        value:
+          enabled: false
+      - channel: developer
+        value:
+          enabled: false
+
diff --git a/firefox-ios/nimbus.fml.yaml b/firefox-ios/nimbus.fml.yaml
@@ -29,6 +29,7 @@ include:
   - nimbus-features/nativeErrorPageFeature.yaml
   - nimbus-features/nightModeFeature.yaml
   - nimbus-features/onboardingFrameworkFeature.yaml
+  - nimbus-features/passwordGeneratorFeature.yaml
   - nimbus-features/reduxSearchSettingsFeature.yaml
   - nimbus-features/remoteTabManagement.yaml
   - nimbus-features/searchFeature.yaml