Bugfix FXIOS-7768 [v120] CFRs are not displayed correctly in landscap…

…e mode (#17338) (#17341) * Use UIAdaptivePresentationControllerDelegate for presenting * Set isPresenting property to true to avoid CFR dismissal (cherry picked from commit 87f69df) Co-authored-by: PARAIPAN SORIN <[email protected]>
mozilla-mobile · Nov 17, 2023 · 11de447 · 11de447 · firefoxci-taskcluster · Nov 17, 2023
1 parent 434967c
commit 11de447
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/Client/Frontend/Home/HomepageViewController.swift b/Client/Frontend/Home/HomepageViewController.swift
@@ -426,7 +426,7 @@ class HomepageViewController: UIViewController, FeatureFlaggable, Themeable, Con
             contextualHintViewController.stopTimer()
             return
         }
-
+        contextualHintViewController.isPresenting = true
         present(contextualHintViewController, animated: true, completion: nil)
 
         UIAccessibility.post(notification: .layoutChanged, argument: contextualHintViewController)
@@ -739,15 +739,21 @@ extension HomepageViewController: UIPopoverPresentationControllerDelegate {
         popoverPresentationController.presentedViewController.dismiss(animated: false, completion: nil)
     }
 
-    func adaptivePresentationStyle(for controller: UIPresentationController) -> UIModalPresentationStyle {
-        return .none
-    }
-
     func presentationControllerShouldDismiss(_ presentationController: UIPresentationController) -> Bool {
         return true
     }
 }
 
+// MARK: - UIAdaptivePresentationControllerDelegate
+extension HomepageViewController: UIAdaptivePresentationControllerDelegate {
+    func adaptivePresentationStyle(
+        for controller: UIPresentationController,
+        traitCollection: UITraitCollection
+    ) -> UIModalPresentationStyle {
+        .none
+    }
+}
+
 // MARK: FirefoxHomeViewModelDelegate
 extension HomepageViewController: HomepageViewModelDelegate {
     func reloadView() {