Docker #112
Closed
Docker #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the custom docker-image tag
escapewindow
reviewed
Apr 8, 2021
| @@ -124,6 +124,32 @@ Once Taskcluster CI automation is enabled, you will see a decision task (and rel | |||
| - a file under `taskcluster/` | |||
| - or a file under the package directory have been changed since the previous test run. | |||
|
|
|||
| - Custom tooling needs - If you need extra npm's installed or a different version of node, here are some options | |||
There was a problem hiding this comment.
We could do this, or start a new subsection with
### Custom tooling needs
| ``` | ||
| { | ||
| "devDependencies": { | ||
| "superawesomepackage": "^3.1.4", |
There was a problem hiding this comment.
Hm, does this work? Do we install devDependencies in the build/test?
| @@ -16,6 +16,9 @@ additional-emails: [] | |||
| # the xpi package.json lives. Optional. Defaults to the | |||
| # root of the repository. | |||
| directory: one | |||
| # string: docker-image. Optional. Defaults to node-14 as found | |||
| # in taskcluster/ci/[build|test]/kind.yml . | |||
| docker-image: node-14 | |||
There was a problem hiding this comment.
Hm, I'm trying to figure out why this and the below changes are showing up here.
Didn't we merge these in #111? I see the changes in https://github.com/mozilla-extensions/xpi-manifest/blob/master/manifests/template-example.yml.template#L19-L21
|
now #115 (I created a fresh branch so I wouldn't be including old changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.