Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3-pip for rally #109

Merged
merged 1 commit into from
Mar 31, 2021
Merged

python3-pip for rally #109

merged 1 commit into from
Mar 31, 2021

Conversation

escapewindow
Copy link
Contributor

No description provided.

@escapewindow escapewindow marked this pull request as ready for review March 31, 2021 17:02
@escapewindow escapewindow requested a review from a team March 31, 2021 17:02
jmaher
jmaher approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@jmaher jmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@escapewindow
Copy link
Contributor Author

Thanks!
Let's land this. If we have any issues with other addons, we may have to accelerate fixing #108 . (I'm planning on having us tackle that issue in Sprint 6, anyway.)

@escapewindow escapewindow merged commit 052f2e5 into mozilla-extensions:master Mar 31, 2021
@escapewindow
Copy link
Contributor Author

For posterity: the python3.7 package appears to no longer be installable on the node 14 docker image, so we had to upgrade to py3.9 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaher jmaher jmaher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escapewindow @jmaher