-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] MIP-0 : Introduce status terms and editor role #32
Open
apenzk
wants to merge
15
commits into
main
Choose a base branch
from
update/Status-terms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7ab5b5e
init
apenzk e87aecb
who does what
apenzk 89acb12
update files and numbering
apenzk 3e583a9
Merge branch 'main' into update/Status-terms
apenzk da56268
Merge branch 'main' into update/Status-terms
apenzk de02a53
interim editor
apenzk c2bfc24
fix error
apenzk b6f369e
remove text on overview file
apenzk 98d1326
add update status
apenzk ad2ba82
clarification how to get MIP number
apenzk f101f97
add editors
apenzk 42f28b4
update editors
apenzk cf87865
conflict resolution
apenzk e9ce1c7
Update README.md
apenzk 81b9077
numbering
apenzk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue that may arise is: suppose an editor has a technical change that the author doesn't agree with. Is there some mechanism that we could add, to resolve such disagreements or disputes?
Likewise, if, say, editors aren't available for timely reviews (which perhaps could happen due to various circumstances), should there be a process for allowing an interim editor to assume editorial responsibilities as needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this handled with PRs in other repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i have addressed now the second para in the text)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PRs, we have a minimum number of approvals needed (3 for MIPs, 2 for PRs to
aptos-core
and 1 for PRs tomovement
).What about this solution: If an editor requests a change from an author, either the author can make the changes (tacitly approving the editorial feedback), or:
If the author doesn't agree with the rquested changes, then the editor can mandate that the author implements the changes by getting 2 upvotes on their discussion comment mentioning the changes (assuming change requests will be made in the Discussion section of the MIP PR)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. added this. thx!