Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications needed for the tutorials #543

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Oct 9, 2020

Description

Based on @tylerjw's TODO list from ros-planning/panda_moveit_config/pull/74#issuecomment-703139739 I started to modify the tutorials in order to fix the broken things.

Checklist

  • [ ] Update video and images for "Move Group C++ Interface"
  • Fix the position of the box in the "Move Group Python Interface" so it is in between the fingers. -> I shrank the box a little bit to fit between the fingers
  • [ ] Update MSA tutorial to include instructions for the default positions of the end effector.
  • [ ] Clarify the "Example" section of "Benchmarking" to include instructions for the collision scene objects.
  • [ ] Add instructions to "Benchmarking" for building warehouse_ros_mongo from source until it is released to Noetic.
  • Add note to tutorials README.md that rosdoc_lite is needed to run the build_locally.sh script.
  • [ ] Fix "Planning Scene ROS API" tutorial to spawn the object in the gripper and remove it from the world in the last step.
  • [ ] Fix "Visualizing Collisions"
  • [ ] Fix "Subframes" tutorial
  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes. I tested the python interface tutorial and the changes work for me. I'd suggest we just merge this change and you create new PRs for future issues.

@sjahr
Copy link
Contributor Author

sjahr commented Oct 12, 2020

Thank you for these changes. I tested the python interface tutorial and the changes work for me. I'd suggest we just merge this change and you create new PRs for future issues.

Sure, sounds good to me.

@sjahr sjahr changed the title WIP: Modifications needed for the tutorials Modifications needed for the tutorials Oct 12, 2020
@tylerjw tylerjw merged commit 3c90b71 into moveit:master Oct 13, 2020
@welcome
Copy link

welcome bot commented Oct 13, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@sjahr sjahr deleted the necessary_tutorial_modifications branch September 8, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants