Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max cartesian end-effector speed in planning pipeline #277

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gautz
Copy link

@gautz gautz commented Jun 25, 2021

Enable trajectory post-processing in planning pipeline to set maximum cartesian end-effector speed.
Requires following to be merged:

How to use? Instead of setProperty("max_velocity_scaling_factor", velocity);, use:

pipeline_planner->setProperty("max_cartesian_speed", velocity); // cartesian_velocity
pipeline_planner->setProperty("cartesian_speed_end_effector_link", welding_tcp_frame_);

I will also implement it in the cartesian demo.

Solves #276

@gautz
Copy link
Author

gautz commented Jun 25, 2021

I tested this successfully in the pick_place_task to set velocity of the hand when moving the panda_arm with the pipeline planner. For instance I can set:

  • Move-to pre-grasp with max free_space_velocity_=1 [m/s]
  • Move-to place with max approach_velocity_=0.1 [m/s]

Do you see a better pipeline planner demo where to set the max cartesian velocity?

@v4hn
Copy link
Contributor

v4hn commented Jun 25, 2021

Do you see a better pipeline planner demo where to set the max cartesian velocity?

Instead of squeezing all features into the one demo, I would encourage you to just create a new demo, possibly something that resembles a simple welding trajectory.

@gautz
Copy link
Author

gautz commented Jun 25, 2021

Do you see a better pipeline planner demo where to set the max cartesian velocity?

Instead of squeezing all features into the one demo, I would encourage you to just create a new demo, possibly something that resembles a simple welding trajectory.

Makes sense, we will probably propose a welding demo, but rather in middle-long term.

In shorter term I could propose to adapt the cartesian Demo to use the pipeline planner (Pilz and/or OMPL constrained planning) and set different cartesian velocities in there.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle looks good to me. See the remark below.

core/src/solvers/pipeline_planner.cpp Outdated Show resolved Hide resolved
@gautz
Copy link
Author

gautz commented Jun 30, 2021

I tried to add the explicit call in cartesian_path but I do not manage to get the velocity set in the cartesian demo.

@gautz
Copy link
Author

gautz commented Jul 20, 2021

@rhaschke when using the cartesian_path planner, neither setting max_velocity_scaling_factor nor max_cartesian_speed results in a change in robot velocity. Could it be somehow related to the discussions in #210 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants