Adds get group urdf service #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
marioprats
reviewed
Jan 15, 2024
srv/GetGroupUrdf.srv
Outdated
| @@ -0,0 +1,4 @@ | |||
| string group_name # Name of the planning group for which an URDF is requested | |||
| --- | |||
| bool success # indicate successful run of the service | |||
There was a problem hiding this comment.
Should we add an error_message field, to be filled in if the request fails?
There was a problem hiding this comment.
Good point! Currently, I publish the error details via the log in the move_group node but we can change that to a MoveItErrorMsg and add more information 👍
marioprats
approved these changes
Jan 15, 2024
Abishalini
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by moveit/moveit2#2649