Move Group C++ Interface #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
reviewed
Apr 5, 2021
Comment on lines
+14
to
+16
| install(DIRECTORY config | ||
| DESTINATION share/${PROJECT_NAME} | ||
| ) |
There was a problem hiding this comment.
We should use the YAML files from moveit_resources
Suggested change
| install(DIRECTORY config | |
| DESTINATION share/${PROJECT_NAME} | |
| ) |
JafarAbdi
requested changes
Apr 5, 2021
| parameters=[robot_description]) | ||
|
|
||
| # Fake joint driver | ||
| fake_joint_driver_node = Node(package='fake_joint_driver', |
There was a problem hiding this comment.
We replaced this node with the one from ros2_control see
|
Changes were added in #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial port of the Move Group C++ Interface tutorial and addresses #2 . This tutorial is very similar to moveit2_demo_nodes/run_move_group which is where I grabbed the launch files.
To test this code run the following:
ros2 launch moveit2_tutorials move_group.launch.pyros2 launch moveit2_tutorials move_group_interface_tutorial.launch.pyItems that I still need to address:
xterminstalledChecklist