Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang version 14->15 #3057

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update clang version 14->15 #3057

wants to merge 3 commits into from

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Nov 3, 2024

clang 15 have a lot of fix and improvements :
https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html

this patch also update
psf/black and pre-commit-hooks

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you want to update the clang-format version to 17, you may need this CI job to run in ubuntu 24.04.

Also, this upgrade cannot really happen for all the Humble tests because those are tied to 22.04.

clang 15 have a lot of fix and improvements :
https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html

this patch also update
psf/black and pre-commit-hooks
@mosfet80
Copy link
Contributor Author

mosfet80 commented Nov 3, 2024

I think if you want to update the clang-format version to 17, you may need this CI job to run in ubuntu 24.04.

Also, this upgrade cannot really happen for all the Humble tests because those are tied to 22.04.

..fixed. ubuntu 20.04 use clang 15.

@mosfet80 mosfet80 changed the title Update c++ standard Update clang version 14->15 Nov 3, 2024
@sea-bass
Copy link
Contributor

sea-bass commented Nov 4, 2024

While clang version 15 is available on Ubuntu 22.04, it's not really the standard version as shown here: https://launchpad.net/ubuntu/jammy/+package/clang-format

So I might suggest to keep it at version 14 for all 22.04 jobs, and whereas 16 and 18 can be used for 24.04 jobs.

But if you want to keep around the pre-commit updates and small linting fixes, I'd be OK merging those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants