Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy CI and build status #2851

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
47f1293
Test CI on ROS 2 Jazzy
henningkayser May 24, 2024
2861a53
Add Jazzy build badges
henningkayser May 24, 2024
a37b670
Only source generate_parameter_library for Humble and Iron
henningkayser May 24, 2024
d0b8299
Switch testspace subdomain to moveit
henningkayser May 24, 2024
9c5bbd4
Temporarily disable testspace in CI
henningkayser May 24, 2024
0ce5d48
Update README Rolling badges to noble
henningkayser May 24, 2024
8bdc819
Remove octomap, geometric_shapes from rolling repos
henningkayser May 24, 2024
7d9aacf
Remove unused variable in test, fix clang-tidy
henningkayser May 24, 2024
dac7638
TEMP: Remove ROS' octomap after 'rosdep install'
rhaschke May 26, 2024
97528ce
Silence clang warnings
henningkayser Jun 6, 2024
889c112
Source geometric_shapes
henningkayser Jun 6, 2024
48f60c4
Fix double-free in Pilz unit tests (#3561)
rhaschke Feb 6, 2024
7f691cd
Fix clang-format
henningkayser Jun 7, 2024
fb5421c
Revert "Fix double-free in Pilz unit tests (#3561)"
henningkayser Jun 7, 2024
578572f
Temporarily disable mock testing in PILZ
henningkayser Jun 7, 2024
4082252
Enforce liboctomap-dev by using a cmake version range
henningkayser Jun 7, 2024
d2270ef
Test geometric_shapes with fixed octomap version
henningkayser Jun 7, 2024
ee147c7
Fix clang-format
henningkayser Jun 7, 2024
14bc36e
Fix warning suppression in ikfast
henningkayser Jun 7, 2024
f54c718
Revert "Simplify controller manager namespacing (#2210)"
henningkayser Jun 7, 2024
d3a11e0
Revert "TEMP: Remove ROS' octomap after 'rosdep install'"
rhaschke Jun 8, 2024
4df4ea4
Revert "Test geometric_shapes with fixed octomap version"
rhaschke Jun 8, 2024
b9de8bc
Silence clang warnings
rhaschke Jun 8, 2024
16f7878
CI: Drop jazzy-ci-testing
rhaschke Jun 8, 2024
944ac8d
Fix -Wmaybe-uninitialized for clang
rhaschke Jun 8, 2024
a7ce893
Fix clang-tidy config
rhaschke Jun 8, 2024
2aa76e3
Apply clang-tidy fixes
rhaschke Jun 8, 2024
46fe5be
Disable clang-tidy for ikfast plugin in moveit_planners/test_configs
rhaschke Jun 9, 2024
9edfd66
Remove Testspace from Sonarcloud
henningkayser Jun 10, 2024
efe14bd
Suppress "mismatch" action
henningkayser Jun 10, 2024
1f61935
Merge branch 'main' into jazzy_support
sjahr Jun 12, 2024
eee39e4
Merge branch 'main' into jazzy_support
sjahr Jun 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
ROS_DISTRO: humble
- IMAGE: humble-ci-testing
ROS_DISTRO: humble
- IMAGE: jazzy-ci
ROS_DISTRO: jazzy
- IMAGE: jazzy-ci-testing
ROS_DISTRO: jazzy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that ci and ci-testing are identical since #2793: Because osrf/ros2:testing (the base image of ci-testing) was broken upstream at the time, I disabled building it and aliased it to ci.

Suggested change
- IMAGE: jazzy-ci-testing
ROS_DISTRO: jazzy

env:
CXXFLAGS: >-
-Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls
Expand Down Expand Up @@ -83,10 +87,12 @@ jobs:
sudo rm -rf /usr/local
df -h
- uses: actions/checkout@v4
- uses: testspace-com/setup-testspace@v1
if: github.repository == 'moveit/moveit2'
with:
domain: ros-planning
# NOTE: Testspace is temporarily disabled and needs to be installed for the MoveIt org
# See: https://github.com/moveit/moveit2/issues/2852
# - uses: testspace-com/setup-testspace@v1
# if: github.repository == 'moveit/moveit2'
# with:
# domain: moveit
- name: Get latest release date for rosdistro
id: rosdistro_release_date
uses: JafarAbdi/latest-rosdistro-release-date-action@main
Expand Down Expand Up @@ -140,10 +146,12 @@ jobs:
name: Run industrial_ci
uses: ros-industrial/industrial_ci@master
env: ${{ matrix.env }}
- name: Push result to Testspace
if: always() && (github.repository == 'moveit/moveit2')
run: |
testspace "[ ${{ matrix.env.IMAGE }} ]${{ env.BASEDIR }}/target_ws/**/test_results/**/*.xml"
# NOTE: Testspace is temporarily disabled and needs to be installed for the MoveIt org
# See: https://github.com/moveit/moveit2/issues/2852
# - name: Push result to Testspace
# if: always() && (github.repository == 'moveit/moveit2')
# run: |
# testspace "[ ${{ matrix.env.IMAGE }} ]${{ env.BASEDIR }}/target_ws/**/test_results/**/*.xml"
- name: Upload test artifacts (on failure)
uses: actions/upload-artifact@v4
if: failure() && (steps.ici.outputs.run_target_test || steps.ici.outputs.target_test_results)
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ROS_DISTRO: [rolling]
ROS_DISTRO: [rolling, jazzy]
runs-on: ubuntu-latest
permissions:
packages: write
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ROS_DISTRO: [rolling]
ROS_DISTRO: [rolling, jazzy]
runs-on: ubuntu-latest
permissions:
packages: write
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ROS_DISTRO: [rolling]
ROS_DISTRO: [rolling, jazzy]
runs-on: ubuntu-latest
permissions:
packages: write
Expand Down
83 changes: 39 additions & 44 deletions README.md

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions moveit2.repos
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ repositories:
type: git
url: https://github.com/ros-planning/moveit_resources.git
version: ros2
generate_parameter_library:
type: git
url: https://github.com/PickNikRobotics/generate_parameter_library.git
version: 0.3.7
5 changes: 5 additions & 0 deletions moveit2_humble.repos
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
repositories:
generate_parameter_library:
type: git
url: https://github.com/PickNikRobotics/generate_parameter_library.git
version: 0.3.7
5 changes: 5 additions & 0 deletions moveit2_iron.repos
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
repositories:
generate_parameter_library:
type: git
url: https://github.com/PickNikRobotics/generate_parameter_library.git
version: 0.3.7
8 changes: 0 additions & 8 deletions moveit2_rolling.repos
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
repositories:
octomap:
type: git
url: https://github.com/octomap/octomap.git
version: devel
geometric_shapes:
type: git
url: https://github.com/moveit/geometric_shapes.git
version: ros2
3 changes: 0 additions & 3 deletions moveit_core/distance_field/test/test_distance_field.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -807,20 +807,17 @@ TEST(TestSignedPropagationDistanceField, TestPerformance)
PERF_ORIGIN_Z, PERF_MAX_DIST, true);

EigenSTL::vector_Vector3d bad_vec;
unsigned int count = 0;
for (unsigned int z = UNIFORM_DISTANCE; z < worstdfu.getZNumCells() - UNIFORM_DISTANCE; z += UNIFORM_DISTANCE)
{
for (unsigned int x = UNIFORM_DISTANCE; x < worstdfu.getXNumCells() - UNIFORM_DISTANCE; x += UNIFORM_DISTANCE)
{
for (unsigned int y = UNIFORM_DISTANCE; y < worstdfu.getYNumCells() - UNIFORM_DISTANCE; y += UNIFORM_DISTANCE)
{
count++;
Eigen::Vector3d loc;
bool valid = worstdfu.gridToWorld(x, y, z, loc.x(), loc.y(), loc.z());

if (!valid)
{
// RCLCPP_WARN("distance_field", "Something wrong");
continue;
}
bad_vec.push_back(loc);
Expand Down
Loading