-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make moveit_servo
listen to Octomap updates (backport #2601)
#2606
Conversation
* Start servo's world geometry monitor * Typo fix --------- Co-authored-by: Amal Nanavati <[email protected]> (cherry picked from commit 87d5945) # Conflicts: # moveit_ros/moveit_servo/src/utils/common.cpp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #2606 +/- ##
==========================================
+ Coverage 50.95% 51.32% +0.38%
==========================================
Files 382 382
Lines 31894 31890 -4
==========================================
+ Hits 16247 16363 +116
+ Misses 15647 15527 -120 ☔ View full report in Codecov by Sentry. |
Yup backporting to humble via cherry-picking will be pretty involved, since the servo code underwent a lot of restructuring. The one-line change that was applied in I'm happy to make the change, although I'm not sure about the norms re. fixing backports. Let me know if y'all have a preferred way of doing this! |
5860867
to
eb279ca
Compare
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
@henningkayser can this be merged? |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
@henningkayser @sea-bass is there something we're waiting on for this PR to be merged? |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This is an automatic backport of pull request #2601 done by Mergify.
Cherry-pick of 87d5945 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com