Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tutorial docker #2451

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Rename tutorial docker #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/tutorial-source/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax = docker/dockerfile:1.3

# ghcr.io/ros-planning/moveit2:main-tutorial-${ROS_DISTRO}
# ghcr.io/ros-planning/moveit2:main-${ROS_DISTRO}-tutorial-source
MarqRazz marked this conversation as resolved.
Show resolved Hide resolved
# Source build of the repos file from the tutorail site

ARG ROS_DISTRO=rolling
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tutorial_docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
packages: write
contents: read
env:
GH_IMAGE: ghcr.io/ros-planning/moveit2:main-tutorial-${{ matrix.ROS_DISTRO }}-${{ github.job }}
DH_IMAGE: moveit/moveit2:main-tutorial-${{ matrix.ROS_DISTRO }}-${{ github.job }}
GH_IMAGE: ghcr.io/ros-planning/moveit2:main-${{ matrix.ROS_DISTRO }}-${{ github.job }}
DH_IMAGE: moveit/moveit2:main-${{ matrix.ROS_DISTRO }}-${{ github.job }}
Comment on lines -24 to +25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarqRazz here is the real technical change.

ROS_DISTRO expands to humble, rolling, or iron
github.job expands to tutorial-source

so a full name will in the form main-humble-tutorial-source

PUSH: ${{ (github.event_name != 'pull_request') && (github.repository == 'ros-planning/moveit2') }}

steps:
Expand Down
Loading