Make msys live inside overridden config path by default (alire-projec…

…t#1589)

* Don't run OS initialization during elaboration

As this makes impossible to tweak such initialization with `alr config`.

* Make msys live inside overriden config path by default

* Better explanation in alr.py

* Fix config loading before Windows builtins

src/alire/alire-config-edit-early_load.adb

@@ -9,4 +9,6 @@ package body Alire.Config.Edit.Early_Load is
       Alire.Config.Edit.Load_Config;
    end Load_Config;
 
+begin
+   Load_Config;
 end Alire.Config.Edit.Early_Load;

src/alire/alire-config-edit-early_load.ads

@@ -1,4 +1,4 @@
-package Alire.Config.Edit.Early_Load is
+package Alire.Config.Edit.Early_Load with Elaborate_Body is
 
    procedure Load_Config;
    --  For internal use of Alire_Early_Elaboration, DO NOT CALL otherwise.

src/alire/alire-platforms-folders.ads

@@ -2,6 +2,10 @@ package Alire.Platforms.Folders is
 
    --  This spec must be fulfilled by bodies for each different OS we support
 
+   --  IMPORTANT NOTE: these are not intended to be used directly in most
+   --  cases; instead, use the ones in Alire.Config.Edit that take into
+   --  account user overriding of the config location.
+
    function Config return Absolute_Path;
    --  Folder where alire will store its global configuration, indexes, and
    --  any other global data. Deleting it is akin to running alr afresh for

src/alire/os_windows/alire-config-builtins-windows.ads

@@ -1,4 +1,6 @@
-with Alire.Platforms.Folders;
+--  Ensure config is loaded for some defaults below
+with Alire.Config.Edit.Early_Load;
+pragma Unreferenced (Alire.Config.Edit.Early_Load);
 
 package Alire.Config.Builtins.Windows is
 
@@ -19,7 +21,7 @@ package Alire.Config.Builtins.Windows is
    Msys2_Install_Dir : constant Builtin := New_Builtin
      (Key  => "msys2.install_dir",
       Kind => Cfg_Absolute_Path,
-      Def  => Platforms.Folders.Cache / "msys64",
+      Def  => Config.Edit.Cache_Path / "msys64",
       Help =>
         "Directory where Alire will detect and/or install" &
         " msys2 system package manager. (Windows only)");

testsuite/drivers/alr.py

@@ -47,6 +47,17 @@ def prepare_env(config_dir, env):
     #  We pass config location explicitly in the following calls since env is
     #  not yet applied (it's just a dict to be passed later to subprocess)
 
+    if platform.system() == "Windows":
+        # Disable msys inadvertent installation
+        run_alr("-c", config_dir, "config", "--global",
+                "--set", "msys2.do_not_install", "true")
+
+        # And configure the one set up in the environment so it is used by
+        # tests that need it.
+        run_alr("-c", config_dir, "config", "--global",
+                "--set", "msys2.install_dir",
+                os.path.join(os.environ.get("LocalAppData"), "alire", "msys64"))
+
     # Disable autoconfig of the community index, to prevent unintended use of
     # it in tests, besides the overload of fetching it
     run_alr("-c", config_dir, "config", "--global",