Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nano precision option. #283

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Add nano precision option. #283

merged 3 commits into from
Apr 10, 2024

Conversation

ChrisDev83
Copy link
Contributor

Unsure whether to add test as existing tests dont test the format as it is. Feel free to tweak as needed!

Unsure whether to add test as existing tests dont test the format as it is.
@mostafa
Copy link
Owner

mostafa commented Apr 10, 2024

Hey @ChrisDev83,

Thanks for your contribution! What do you think about making the entire time format optional and including all supported formats? This will include exporting the time formats as constants to be passed as the format as string, instead of nanoPrecision boolean value.

@ChrisDev83
Copy link
Contributor Author

That would be a better approach, I found the formats odd as I come from "YYYY-mm-dd" world! But definitely more flexible that way.

@ChrisDev83
Copy link
Contributor Author

Actually, I remember why I went against the string format. I felt that given this is for k6 and the test config is written in Javascript, you need to know the format of go date/time format. So you would be supplying a go format in a javascript file. Unless you could allow a javascript date format and have a method to convert that to go format?

@mostafa
Copy link
Owner

mostafa commented Apr 10, 2024

@ChrisDev83 Let's keep this as is and open an issue to discuss that. Okay?

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mostafa mostafa merged commit 0fdd2e1 into mostafa:main Apr 10, 2024
3 checks passed
@ChrisDev83
Copy link
Contributor Author

This current open issue is related

@mostafa
Copy link
Owner

mostafa commented Apr 10, 2024

Released in v0.24.2.

@mostafa
Copy link
Owner

mostafa commented Apr 10, 2024

@ChrisDev83 Then, please update it with our discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants