Mosip 29868 #1785
Mosip 29868 #1785
Conversation
Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>
Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>
sowmya695
force-pushed
the
MOSIP-29868
branch
from
5808b40
to
2465462
Compare
|
Cancelling the PR as we discussed about different approach. |
| .trimExceptionMessage( | ||
| StatusUtil.DEMO_DEDUPE_PACKET_MANAGER_EXCEPTION.getMessage() + e.getMessage())); | ||
| registrationStatusDto.setSubStatusCode(StatusUtil.DEMO_DEDUPE_PACKET_MANAGER_EXCEPTION.getCode()); | ||
| registrationStatusDto.setLatestTransactionStatusCode(registrationExceptionMapperUtil |
There was a problem hiding this comment.
this exception is marked as reprocess, in what scenarios we are getting this exception ?
| public Map<String, List<String>> createTypeSubtypeMapping() throws ApisResourceAccessException, DataShareException, | ||
| JsonParseException, JsonMappingException, com.fasterxml.jackson.core.JsonProcessingException, IOException { | ||
| Map<String, List<String>> typeAndSubTypeMap = new HashMap<>(); | ||
| ResponseWrapper<?> policyResponse = (ResponseWrapper<?>) registrationProcessorRestClientService.getApi( |
There was a problem hiding this comment.
should we cache this policy with a fixed expiry to improve performance ?
| return isDataSaved; | ||
| } | ||
|
|
||
| public Map<String, List<String>> createTypeSubtypeMapping() throws ApisResourceAccessException, DataShareException, |
There was a problem hiding this comment.
We should rename this method, to convey we are fetch the modality and segment map for ABIS partner.
| return isDataSaved; | ||
| } | ||
|
|
||
| public Map<String, List<String>> createTypeSubtypeMapping() throws ApisResourceAccessException, DataShareException, |
There was a problem hiding this comment.
I believe it is also possible to configured multiple ABIS for each modality, not sure if 1.1.5.x support this. But if that is supported, then this logic needs to change.
...age/src/main/java/io/mosip/registration/processor/stages/demodedupe/DemodedupeProcessor.java
Show resolved
Hide resolved
| if (modalities == null || modalities.isEmpty()) { | ||
| throw new BiometricRecordValidationException( | ||
| PlatformErrorMessages.RPR_DEMO_DATASHARE_MODALITIES_EMPTY.getCode(), | ||
| PlatformErrorMessages.RPR_DEMO_DATASHARE_MODALITIES_EMPTY.getMessage()); |
There was a problem hiding this comment.
Using the datashare name in these validations are confusing, since datashare is mearly a transport mechanism. We should say something releated to ABIS or biometrics required for biodedup is not present etc..
No description provided.