Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOSIP-29593 Record status comment for failed status #831

Open
wants to merge 1 commit into
base: 1.1.4.4
Choose a base branch
from

Conversation

Neha2365
Copy link
Contributor

@Neha2365 Neha2365 commented Oct 3, 2023

No description provided.

Copy link
Member

@vishwa-vyom vishwa-vyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are good, since we are connecting to 1.1.5.5, it works but someone running 1.1.4.4, it will cause consistency issue, lets discuss on this to Rounak and Loga once.

@@ -74,6 +74,9 @@ public class CredentialEntity {
/** The deleted date time. */
@Column(name = "del_dtimes")
private LocalDateTime deletedDateTime;

@Column(name = "status_comment")
private String statusComment;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the default db schema of 1.1.4.4 we might not have this field, this change will cause consistence issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants