Output eval logging batch #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* relax atol and add retries to reduce flakiness in lion8b timing test
… into output_eval_logging
bmosaicml
approved these changes
Mar 11, 2024
|
Might need to wait for composer release ( |
…lm-foundry into output_eval_logging_batch
|
@maxisawesome now that Composer 0.21 is out, is this still blocked? |
|
yes @nik-mosaic I'm running some tests and then will merge |
maxisawesome
changed the title
dakinggg
approved these changes
Mar 28, 2024
j316chuck
approved these changes
Mar 28, 2024
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Skip flaky lion8b test (#598) * relax atol and add retries to reduce flakiness in lion8b timing test * add eval output logging * add back tasks * foo * add rlhf prompts * add rlhf prompts * add rlhf prompts * add rlhf prompts * add rlhf prompts * fix prompt * fix prompt * modify mcli * test * test * fix * fix merge * wip * merge * reset files, wip commit * rm small changes * reduce changes * reduce changes * . * wip * rm batch keys * revert init device * linting * add import * fix import * add eval_output_logging to registry * readd import * pyright + linting --------- Co-authored-by: dblalock <[email protected]> Co-authored-by: Jeremy Dohmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with adding output eval logging callback for eval.py. Works with recent changes to composer
Required in your yaml:
test run here: `test-batch-logging-izC0mH
wandb logged results here: https://wandb.ai/mosaic-ml/test-eval-logging/runs/km61skch/workspace