Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script sys path back to test #797

Closed
wants to merge 4 commits into from
Closed

Add script sys path back to test #797

wants to merge 4 commits into from

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented Dec 11, 2023

No description provided.

@aspfohl aspfohl requested a review from vchiley December 11, 2023 21:44
from llmfoundry.callbacks import HuggingFaceCheckpointer
from llmfoundry.models.mpt.modeling_mpt import ComposerMPTCausalLM

# Add repo root to path so we can import scripts and test it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this wasn't handled by the fixtures? / Why were these tests passing in CI?

@aspfohl aspfohl closed this Jan 2, 2024
@aspfohl aspfohl deleted the anna/syspath branch January 2, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants