Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade composer version #560

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Aug 25, 2023

@dakinggg dakinggg marked this pull request as ready for review September 6, 2023 05:28
@dakinggg dakinggg enabled auto-merge (squash) September 6, 2023 05:29
@irenedea
Copy link
Contributor

irenedea commented Sep 6, 2023

@dakinggg What should we generally look for with the regression tests you posted? I suppose decreasing loss for training?

@dakinggg
Copy link
Collaborator Author

dakinggg commented Sep 6, 2023

I'm just comparing to my previous runs of them. Each run is a group within that wandb project. Once Chuck's stuff is done they will be compared against a fixed "golden" run.

@dakinggg
Copy link
Collaborator Author

dakinggg commented Sep 6, 2023

So in this case I'm just seeing that the curves and number are identical to the ones I ran before.

@dakinggg
Copy link
Collaborator Author

dakinggg commented Sep 6, 2023

Although one of the runs actually failed...so looking into that now

@dakinggg
Copy link
Collaborator Author

dakinggg commented Sep 6, 2023

Ok one of them didn't actually ever run and I just missed it on my original PR. Gonna update in this PR.

@dakinggg
Copy link
Collaborator Author

dakinggg commented Sep 6, 2023

Ok, the failing regression test was user erorr. updated to mixed init. I'm comfortable merging given that validation done. We will set up proper regression tests once Chuck's stuff is ready.

@dakinggg dakinggg merged commit 5ec4016 into mosaicml:main Sep 6, 2023
8 checks passed
@dakinggg dakinggg deleted the composer-upgrade branch September 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants