Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make peft installs a extra_dep #397

Merged
merged 8 commits into from
Jun 29, 2023
Merged

make peft installs a extra_dep #397

merged 8 commits into from
Jun 29, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Jun 29, 2023

If I run anything I get this warning:

===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================

this gates the parameter efficient fine tuning installs so that the above only happens if a user wants it to.

@vchiley vchiley self-assigned this Jun 29, 2023
samhavens
samhavens reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@samhavens samhavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think else -> except, otherwise LGTM

llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
@vchiley vchiley requested a review from samhavens June 29, 2023 21:00
samhavens
samhavens previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@samhavens samhavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samhavens samhavens dismissed their stale review June 29, 2023 22:04

Just noticed failing tests

@vchiley vchiley requested a review from samhavens June 29, 2023 22:40
samhavens
samhavens approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@samhavens samhavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2: Return of the LGTM

@vchiley vchiley merged commit 156fcf1 into mosaicml:main Jun 29, 2023
@vchiley vchiley deleted the bnblorapeft_install branch November 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhavens samhavens samhavens approved these changes

@codestar12 codestar12 Awaiting requested review from codestar12

@danbider danbider Awaiting requested review from danbider

Assignees

@vchiley vchiley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchiley @samhavens