Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds max seq len filter before finetuning ds #359

Merged
merged 11 commits into from
Jun 27, 2023
Merged

Adds max seq len filter before finetuning ds #359

merged 11 commits into from
Jun 27, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Jun 22, 2023

@vchiley vchiley assigned vchiley, codestar12 and dakinggg and unassigned vchiley Jun 24, 2023
alextrott16
alextrott16 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@alextrott16 alextrott16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working for me now. I recommend removing the num_proc stuff from the dataset mapping calls because they produce the most horrifying logs and I irrationally distrust them.

Otherwise LGTM. (until of course it breaks mysteriously again)

llmfoundry/data/finetuning/tasks.py Outdated Show resolved Hide resolved
llmfoundry/data/finetuning/tasks.py Outdated Show resolved Hide resolved
@vchiley vchiley merged commit 90795f3 into mosaicml:main Jun 27, 2023
10 checks passed
@vchiley vchiley deleted the dk_hf-hang branch November 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextrott16 alextrott16 alextrott16 approved these changes

Assignees

@codestar12 codestar12

@dakinggg dakinggg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchiley @alextrott16 @codestar12 @dakinggg