Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlflow datasets #1119

Merged
merged 47 commits into from
Apr 24, 2024
Merged

Mlflow datasets #1119

merged 47 commits into from
Apr 24, 2024

Conversation

@KuuCi KuuCi requested a review from a team as a code owner April 18, 2024 18:25
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

llmfoundry/utils/config_utils.py Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
@KuuCi KuuCi requested review from dakinggg and irenedea April 19, 2024 22:24
tests/utils/test_mlflow_logging.py Outdated Show resolved Hide resolved
tests/utils/test_mlflow_logging.py Show resolved Hide resolved
tests/utils/test_mlflow_logging.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Show resolved Hide resolved
llmfoundry/utils/config_utils.py Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
@KuuCi KuuCi requested a review from dakinggg April 23, 2024 09:48
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/config_utils.py Outdated Show resolved Hide resolved
@KuuCi KuuCi merged commit 72da1d7 into main Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants