Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel King <[email protected]>
  • Loading branch information
vchiley and dakinggg committed Nov 28, 2023
1 parent 9607747 commit 6130334
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions llmfoundry/utils/builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def _extract_param_groups(
}
```
To create modify the optimizer parameters for all parameters that contain the
To create and modify the optimizer parameters for all parameters that contain the
string "norm" and "bias" separately:
```
optimizer_config: {
Expand Down Expand Up @@ -219,7 +219,7 @@ def _extract_param_groups(
Returns:
Union[Iterable[torch.Tensor], Iterable[Dict[str, Any]]]: an iterable of
torch.Tensor's or dict's. Specifies what Tensors should be optimized.
torch.Tensor's or dict's. Specifies what Tensors should be optimized and their param groupings.
"""
if 'disable_grad' in optimizer_config.keys():
str_matches = optimizer_config.pop('disable_grad')
Expand Down

0 comments on commit 6130334

Please sign in to comment.