Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPU dailies #3628

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Fix CPU dailies. Runs wandb in offline mode

Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's v useful

@b-chu
Copy link
Contributor

b-chu commented Sep 23, 2024

Shouldn't dailies also test integrations with third party providers? We already have some wandb tests as offline

@mvpatel2000
Copy link
Contributor Author

Shouldn't dailies also test integrations with third party providers? We already have some wandb tests as offline

We don't have keys anymore as we've switched to MLFlow

@mvpatel2000 mvpatel2000 merged commit d2e1d5e into mosaicml:main Sep 23, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-cpu-tests branch September 23, 2024 18:15
@b-chu
Copy link
Contributor

b-chu commented Sep 23, 2024

We should get keys for our team to make sure we can keep supporting wandb integrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants