Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wandb requirement from <0.18,>=0.13.2 to >=0.13.2,<0.19 #3615

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Update wandb requirement from <0.18,>=0.13.2 to >=0.13.2,<0.19 #3615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5f0939
Update wandb requirement from <0.18,>=0.13.2 to >=0.13.2,<0.19
dependabot[bot] Sep 16, 2024
29e6be1
Merge branch 'main' into dependabot/pip/wandb-gte-0.13.2-and-lt-0.19
snarayan21 Sep 16, 2024
8052124
CHUCKPOINTING!
mvpatel2000 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def package_files(prefix: str, directory: str, extension: str):
]

extra_deps['wandb'] = [
'wandb>=0.13.2,<0.18',
'wandb>=0.13.2,<0.19',
]

extra_deps['comet_ml'] = [
Expand Down
4 changes: 2 additions & 2 deletions tests/loggers/test_wandb_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ def test_wandb_log_metrics(test_wandb_logger):
eval_metrics_cross_entropy_count = all_run_text.count('metrics/eval/CrossEntropy')
train_loss_count = all_run_text.count('loss/train/total')

expected_number_train_loss_count = (dataset_size / batch_size) + 1 # wandb includes it in the file one extra time
expected_number_train_loss_count = (dataset_size / batch_size) * 2 # wandb includes it twice per step
expected_number_train_metrics_count = (
dataset_size / batch_size
) + 2 # wandb includes it in the file two extra times
) * 2 + 2 # wandb includes it twice per step plus two extra times
expected_number_eval_metrics_count = 2 # wandb includes it in the file twice
assert train_metrics_accuracy_count == expected_number_train_metrics_count
assert train_loss_count == expected_number_train_loss_count
Expand Down
Loading