Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run TP Checkpoint Tests #3600

Closed
wants to merge 17 commits into from
Closed

Run TP Checkpoint Tests #3600

wants to merge 17 commits into from

Conversation

eitanturok
Copy link
Contributor

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eitanturok eitanturok requested a review from a team as a code owner September 5, 2024 16:04
@eitanturok
Copy link
Contributor Author

Closed because we are unable to checkpoint with TP-FSDP due to this pytorch bug: pytorch/pytorch#134095.

@eitanturok eitanturok closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eitanturok