-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FSDP restriction from PyTorch 1.13 #3395
Remove FSDP restriction from PyTorch 1.13 #3395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but can you include a run name that successfully runs with torch 1.3 and fp32 param_dtype?
It does not run with 1.13, but we've moved off from that and upgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i misunderstood. lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* remove torch 113 * lint
What does this PR do?
Remove FSDP restriction from PyTorch 1.13. We added this to give a friendlier error for users when PyTorch had a bug, but the corresponding issue is closed and fixed and has been patched for a while since PyTorch 2.