log image fix #3286
Merged
log image fix #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
May 14, 2024
jessechancy
force-pushed
the
log-image-fix
branch
from
9e9dc37
to
604c85d
Compare
Signed-off-by: Jesse Chan <[email protected]>
Signed-off-by: Jesse Chan <[email protected]>
jessechancy
force-pushed
the
log-image-fix
branch
from
493148c
to
deed464
Compare
milocress
previously approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Approving to unblock. @mvpatel2000 can you take another look to make sure everything is shipshape? 🚢 🚢 🚢
milocress
reviewed
Jun 13, 2024
milocress
reviewed
Jun 13, 2024
mvpatel2000
reviewed
Jun 14, 2024
mvpatel2000
dismissed
milocress’s stale review
Dismissing since you did changes on PR
Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
* log image fix Signed-off-by: Jesse Chan <[email protected]> * fixed log image tests Signed-off-by: Jesse Chan <[email protected]> * linter Signed-off-by: Jesse Chan <[email protected]> * add simd requirement * post0? * versioning yada yada yada * guh * import fix? * update deps * fix * fix II * remove other dependency * debug statement, remove * post1?! * build from source * whitespace? * use pillow * delete a unit test and ignore some types * s/type/pyright * formatting * formatting * ignore more stuff * Apply suggestions from code review * remove rest * Update setup.py Co-authored-by: Mihir Patel <[email protected]> * try no ignore * remove intenum --------- Signed-off-by: Jesse Chan <[email protected]> Co-authored-by: Daniel King <[email protected]> Co-authored-by: Milo Cress <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
that referenced
this pull request
Jul 21, 2024
* log image fix Signed-off-by: Jesse Chan <[email protected]> * fixed log image tests Signed-off-by: Jesse Chan <[email protected]> * linter Signed-off-by: Jesse Chan <[email protected]> * add simd requirement * post0? * versioning yada yada yada * guh * import fix? * update deps * fix * fix II * remove other dependency * debug statement, remove * post1?! * build from source * whitespace? * use pillow * delete a unit test and ignore some types * s/type/pyright * formatting * formatting * ignore more stuff * Apply suggestions from code review * remove rest * Update setup.py Co-authored-by: Mihir Patel <[email protected]> * try no ignore * remove intenum --------- Signed-off-by: Jesse Chan <[email protected]> Co-authored-by: Daniel King <[email protected]> Co-authored-by: Milo Cress <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates mlflow logger
log_imageto use the new API with time-dimension. This will enable viewing the images in MLflowWhat issue(s) does this change relate to?
Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)