[EASY] Always log 1st batch when resuming training #3009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
composer prints the console logging for 1st batch and every
self.log_interval
batches. but when resuming training, we probably want to print the 1st batch no matter ifcur_batch % self.log_interval == 0
. This PR just forces to print console logging for 1st batch after resumption.test
console_log_interval=7ba
composer train/train.py train/yamls/pretrain/mpt-125m.yaml train_loader.dataset.split=train_small max_duration=10ba eval_interval=0 console_log_interval=7ba load_path=./125m/checkpoints/ep0-ba3-rank0.pt
before the change:
first logged batch is 7
after the change
first logged batch is 4, then 7