Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reusable actions for linting #2948

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Use reusable actions for linting #2948

merged 2 commits into from
Feb 14, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Jan 31, 2024

What does this PR do?

Use reusable actions for linting from the testing repo. The new workflows retrieve a token, check out the testing repo, then run the actions in the testing repo.

@b-chu b-chu force-pushed the cicd branch 14 times, most recently from 90ffbac to 7f33cc8 Compare February 1, 2024 21:09
@b-chu b-chu force-pushed the cicd branch 16 times, most recently from 078fcf1 to 76bdb67 Compare February 14, 2024 00:04
@b-chu b-chu force-pushed the cicd branch 5 times, most recently from a901c5c to f28a7b8 Compare February 14, 2024 17:11
@mvpatel2000
Copy link
Contributor

@b-chu is it possible to test pre-merge to verify it works by triggering action on branch?

@b-chu b-chu changed the title Use reusable workflows Use reusable actions for linting Feb 14, 2024
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you put a more descriptive PR description next time please?

@b-chu b-chu merged commit c47e012 into dev Feb 14, 2024
14 checks passed
@b-chu b-chu deleted the cicd branch February 14, 2024 19:47
mvpatel2000 added a commit that referenced this pull request Feb 16, 2024
mvpatel2000 added a commit that referenced this pull request Feb 16, 2024
b-chu added a commit to b-chu/composer that referenced this pull request Feb 16, 2024
bandish-shah pushed a commit that referenced this pull request Feb 16, 2024
* Use testing repo actions (#2948)
* Change to pull_request_target
b-chu added a commit that referenced this pull request Feb 27, 2024
b-chu added a commit that referenced this pull request Feb 27, 2024
b-chu added a commit that referenced this pull request Feb 27, 2024
* Use testing repo actions (#2948)

* Change to ci repo
j316chuck pushed a commit that referenced this pull request Mar 29, 2024
* Use testing repo actions (#2948)

* Change to ci repo
j316chuck pushed a commit that referenced this pull request May 16, 2024
* Use testing repo actions (#2948)

* Change to ci repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants