Fall back to normal logging when gpu prefix is not present (#3020)

* added new condition * removed a comma * Update composer/cli/launcher.py Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: Mihir Patel <[email protected]>
mosaicml · Feb 16, 2024 · 6096f65 · 6096f65
1 parent 6e28c88
commit 6096f65
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/composer/cli/launcher.py b/composer/cli/launcher.py
@@ -482,9 +482,9 @@ def main():
         args.stderr = f'{log_tmpdir.name}/rank{{rank}}.stderr.txt'
 
     # If running on the Mosaic platform, log all gpu ranks' stderr and stdout to Mosaic platform
-    if os.environ.get(
-            MOSAICML_PLATFORM_ENV_VAR,
-            'false').lower() == 'true' and str(os.environ.get(MOSAICML_LOG_DIR_ENV_VAR, 'false')).lower() != 'false':
+    if os.environ.get(MOSAICML_PLATFORM_ENV_VAR, 'false').lower() == 'true' and str(
+            os.environ.get(MOSAICML_LOG_DIR_ENV_VAR, 'false')).lower() != 'false' and os.environ.get(
+                MOSAICML_GPU_LOG_FILE_PREFIX_ENV_VAR, 'false').lower() != 'false':
         log.info('Logging all GPU ranks to Mosaic Platform.')
         log_file_format = f'{os.environ.get(MOSAICML_LOG_DIR_ENV_VAR)}/{os.environ.get(MOSAICML_GPU_LOG_FILE_PREFIX_ENV_VAR)}{{local_rank}}.txt'
         if args.stderr is not None or args.stdout is not None: