Update wandb requirement from <0.18,>=0.13.2 to >=0.13.2,<0.19 (#3615)

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Saaketh Narayan <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mosaicml · Sep 19, 2024 · 129dcbe · 129dcbe
1 parent 893f398
commit 129dcbe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/setup.py b/setup.py
@@ -160,7 +160,7 @@ def package_files(prefix: str, directory: str, extension: str):
 ]
 
 extra_deps['wandb'] = [
-    'wandb>=0.13.2,<0.18',
+    'wandb>=0.13.2,<0.19',
 ]
 
 extra_deps['comet_ml'] = [

diff --git a/tests/loggers/test_wandb_logger.py b/tests/loggers/test_wandb_logger.py
@@ -269,10 +269,10 @@ def test_wandb_log_metrics(test_wandb_logger):
     eval_metrics_cross_entropy_count = all_run_text.count('metrics/eval/CrossEntropy')
     train_loss_count = all_run_text.count('loss/train/total')
 
-    expected_number_train_loss_count = (dataset_size / batch_size) + 1  # wandb includes it in the file one extra time
+    expected_number_train_loss_count = (dataset_size / batch_size) * 2  # wandb includes it twice per step
     expected_number_train_metrics_count = (
         dataset_size / batch_size
-    ) + 2  # wandb includes it in the file two extra times
+    ) * 2 + 2  # wandb includes it twice per step plus two extra times
     expected_number_eval_metrics_count = 2  # wandb includes it in the file twice
     assert train_metrics_accuracy_count == expected_number_train_metrics_count
     assert train_loss_count == expected_number_train_loss_count