Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URD Whitelisting on Morpho Token #57

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jean-Grimal
Copy link

No description provided.

@Jean-Grimal Jean-Grimal changed the title test: add test Add URD Whitelisting on Morpho Token Jan 29, 2024
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

daoWhitelistUrd

vm.prank(URD);
morphoToken.approve(address(morphoDao), type(uint256).max);

deal(address(morphoToken), URD, 1e18);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test the DAO is able to transfer from the DAO to the URD instead of dealing?

deal(address(morphoToken), URD, 1e18);
vm.prank(URD);
morphoToken.transfer(address(0), 1e18);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could try the transferFrom too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants