docs: update readme #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Grimal
requested review from
Rubilmax,
QGarchery,
MerlinEgalite and
MathisGD
MerlinEgalite
requested changes
Apr 9, 2024
QGarchery
previously approved these changes
Apr 11, 2024
MerlinEgalite
previously approved these changes
Apr 12, 2024
QGarchery
previously approved these changes
Apr 12, 2024
MathisGD
reviewed
Apr 23, 2024
| @@ -46,9 +33,14 @@ To create a new `MorphoChainlinkOracleV2` oracle using the factory, call the `cr | |||
| - `quoteTokenDecimals`: Decimal precision of the quote asset. | |||
| - `salt`: A unique identifier to create deterministic addresses for deployed oracles. | |||
|
|
|||
| ### Deploy an Oracle | |||
| **Warning:** If there is an ERC4626-compliant vault for `baseVault` or `quoteVault`, the `baseTokenDecimals` or `quoteTokenDecimals` are still the decimals of the asset in the vault, and not the decimals of the Vault asset. | |||
| E.g: for a MetaMorpho WETH vault, as `baseVault`, the `baseTokenDecimals` is 18 as WETH has 18 decimals. | |||
There was a problem hiding this comment.
metamorpho also has 18 decimals (and most vaults do), so the example is not perfect
to me we can just remove it
Co-authored-by: MathisGD <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
MerlinEgalite
approved these changes
Apr 26, 2024
|
Apply changes and merged, PR pending for too long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90 and #92